Re: [PATCH 06/10] grep: remove #ifdef NO_PTHREADS
- From
Jeff King <peff@peff.net>
- Date
- Oct 29, 2018, 16:20 UTC
- Message-ID
- <20181029162007.GA31497@sigill.intra.peff.net>
- In-Reply-To
- <CACsJy8Bp_9qmGeNZuywtda1_TdQTZM1essUjBD9Q8e31175V=g@mail.gmail.com>
On Mon, Oct 29, 2018 at 05:01:41PM +0100, Duy Nguyen wrote:
Show 9 quoted lines
> On Mon, Oct 29, 2018 at 3:25 PM Jeff King <peff@peff.net> wrote: > > But if the problem is simply that we are not quite there yet in the grep > > code, I am OK with taking this as the first pass, and knowing that there > > is more cleanup to be done later (though that sort of thing is IMHO very > > useful in a commit message). > > Since the problem pops up now, I'm ok with updating/cleaning up all > this in this series, unless there's benefits in keeping this series > simple and merging it early (probably not?)
Mostly I did not want to tax you. I would rather have this series and some cleanup left over, than to not have anything. But if you are interested in moving it further, I will not say no. :)
-Peff