Re: [PATCH] test-lib: introduce the '-V' short option for '--verbose-log'

From: Jeff King <peff@peff.net>
Date: Oct 29, 2018, 14:21 UTC
Message-ID: <20181029142108.GD17668@sigill.intra.peff.net>
In-Reply-To: <20181029121359.7323-1-szeder.dev@gmail.com>

On Mon, Oct 29, 2018 at 01:13:59PM +0100, SZEDER Gábor wrote:

Show 6 quoted lines

> '--verbose-log' is one of the most useful and thus most frequently
> used test options, but due to its length it's a pain to type on the
> command line.
> 
> Let's introduce the corresponding short option '-V' to save some
> keystrokes.

Interesting. I'm not opposed to something like this, but I added "--verbose-log" specifically for scripted cases, like running an unattended "prove" that needs to preserve stdout. When running individual tests, I'd just use "-v" itself, and possibly redirect the output.

For my curiosity, can you describe your use case a bit more?

>  t/README      | 1 +
>  t/test-lib.sh | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)

The patch itself looks good to me.

-Peff