Re: 'ds/test-multi-pack-index' vs. 'ab/commit-graph-progress'

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Oct 29, 2018, 11:16 UTC
Message-ID: <20181029111632.GR30222@szeder.dev>
In-Reply-To: <87va5plois.fsf@evledraar.gmail.com>

On Thu, Oct 25, 2018 at 11:11:55PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> > Anyway, this test seems to be too fragile, because that
> >
> >   test_line_count = 1 stderr
> 
> Yeah maybe it's too fragile, on the other hand it caught what seems to
> be a bug under GIT_TEST_MULTI_PACK_INDEX=true, and the rest of the test
> suite passes, so there's that.

I can image more prudent approaches that would have done the same, e.g. '! grep ^error stderr'.

Show 11 quoted lines

> > line will trigger, when anything else during 'git gc' prints
> > something.  And I find it quite strange that an option called
> > '--no-quiet' only shows the commit-graph progress, but not the regular
> > output of 'git gc'.
> 
> It's confusing, but the reason for this seeming discrepancy is that
> writing the commit-graph happens in-process, whereas the rest of the
> work done by git-gc (and its output) comes from subprocesses. Most of
> that output is from "git-repack" / "git-pack-objects" which doesn't pay
> the same attention to --quiet and --no-quiet, instead it checks
> isatty(). See cmd_pack_objects().

This explains what implementation details led to the current behaviour, but does not justify the actual inconsistency.