git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] khash: silence -Wunused-function for delta-islands

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Oct 23, 2018, 21:50 UTC
Message-ID
<20181023215020.18550-3-carenas@gmail.com>
In-Reply-To
<20181023215020.18550-1-carenas@gmail.com>

showing the following when compiled with latest clang (OpenBSD, Fedors and macOS):

delta-islands.c:23:1: warning: unused function 'kh_destroy_str'
      [-Wunused-function]
delta-islands.c:23:1: warning: unused function 'kh_clear_str'
      [-Wunused-function]
delta-islands.c:23:1: warning: unused function 'kh_del_str' [-Wunused-function]
Reported-by: René Scharfe <l.s.r@web.de>
Suggested-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 khash.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/khash.h b/khash.h
index c0da40daa7..fb71c92547 100644
--- a/khash.h
+++ b/khash.h
@@ -226,7 +226,7 @@ static const double __ac_HASH_UPPER = 0.77;
 	__KHASH_IMPL(name, SCOPE, khkey_t, khval_t, kh_is_map, __hash_func, __hash_equal)
 
 #define KHASH_INIT(name, khkey_t, khval_t, kh_is_map, __hash_func, __hash_equal) \
-	KHASH_INIT2(name, static inline, khkey_t, khval_t, kh_is_map, __hash_func, __hash_equal)
+	KHASH_INIT2(name, MAYBE_UNUSED static inline, khkey_t, khval_t, kh_is_map, __hash_func, __hash_equal)
 
 /* Other convenient macros... */
 
-- 
2.19.1
Previous: Carlo ArenasNext: René Scharfe
Message 7 of 9 in “khash: silence -Wunused-function”
  1. khash: silence -Wunused-functionCarlo Marcelo Arenas Belón, Oct 23, 2018
  2. Duy NguyenOct 23, 2018
  3. 0/2 delta-islands: avoid unused function messagesCarlo Marcelo Arenas Belón, Oct 23, 2018
  4. 1/2 commit-slabs: move MAYBE_UNUSED outCarlo Marcelo Arenas Belón, Oct 23, 2018
  5. Jeff KingOct 23, 2018
  6. Carlo ArenasOct 23, 2018
  7. 2/2 khash: silence -Wunused-function for delta-islandsCarlo Marcelo Arenas Belón, Oct 23, 2018
  8. René ScharfeOct 23, 2018
  9. Carlo ArenasOct 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.