[PATCH v1 1/1] index_bulk_checkin(): Take off_t, not size_t
- From
tboegi@web.de <tboegi@web.de>
- Date
- Oct 18, 2018, 19:11 UTC
- Message-ID
- <20181018191140.23318-1-tboegi@web.de>
From: Torsten Bögershausen <tboegi@web.de>
When streaming data from disk into a blob, use off_t instead of size_t, which is a better choice for file length.
Signed-off-by: Torsten Bögershausen <tboegi@web.de> ---
This is based on an old patch from 2017, which never made it to the list. I think it make sense to have off_t/size_t more consistent, reviews/comments are welcome.
bulk-checkin.c | 4 ++-- bulk-checkin.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/bulk-checkin.c b/bulk-checkin.c index 409ecb566b..2631e82d6c 100644 --- a/bulk-checkin.c +++ b/bulk-checkin.c @@ -189,7 +189,7 @@ static void prepare_to_stream(struct bulk_checkin_state *state, static int deflate_to_pack(struct bulk_checkin_state *state, struct object_id *result_oid, - int fd, size_t size, + int fd, off_t size, enum object_type type, const char *path, unsigned flags) { @@ -258,7 +258,7 @@ static int deflate_to_pack(struct bulk_checkin_state *state, } int index_bulk_checkin(struct object_id *oid, - int fd, size_t size, enum object_type type, + int fd, off_t size, enum object_type type, const char *path, unsigned flags) { int status = deflate_to_pack(&state, oid, fd, size, type, diff --git a/bulk-checkin.h b/bulk-checkin.h index f438f93811..09b2affdf3 100644 --- a/bulk-checkin.h +++ b/bulk-checkin.h @@ -7,7 +7,7 @@ #include "cache.h" extern int index_bulk_checkin(struct object_id *oid, - int fd, size_t size, enum object_type type, + int fd, off_t size, enum object_type type, const char *path, unsigned flags); extern void plug_bulk_checkin(void);
-- 2.19.0.271.gfe8321ec05