Re: [PATCH] config.mak.dev: enable -Wunused-function

From: Jeff King <peff@peff.net>
Date: Oct 18, 2018, 07:08 UTC
Message-ID: <20181018070831.GA29542@sigill.intra.peff.net>
In-Reply-To: <20181018070522.GA29499@sigill.intra.peff.net>

On Thu, Oct 18, 2018 at 03:05:22AM -0400, Jeff King wrote:

Show 10 quoted lines

> diff --git a/config.mak.dev b/config.mak.dev
> index 92d268137f..bbeeff44fe 100644
> --- a/config.mak.dev
> +++ b/config.mak.dev
> @@ -34,7 +34,6 @@ ifeq ($(filter extra-all,$(DEVOPTS)),)
>  CFLAGS += -Wno-empty-body
>  CFLAGS += -Wno-missing-field-initializers
>  CFLAGS += -Wno-sign-compare
> -CFLAGS += -Wno-unused-function
>  CFLAGS += -Wno-unused-parameter

By the way, I wondered how close we were to being able to use -Wunused-parameter. The answer is "not very".

However, I've been digging into the results, and it does find a number of bugs. I'm 168 (rough) patches deep right now, and I have it compiling cleanly. Most of those are just annotations, but I'll start posting fixes as I organize and clean them up.

-Peff