Re: [PATCH] builtin/submodule--helper: remove debugging leftover tracing

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 17, 2018, 02:52 UTC
Message-ID: <20181017025213.GB117170@aiede.svl.corp.google.com>
In-Reply-To: <20181016234550.216587-1-sbeller@google.com>

Stefan Beller wrote:

Show 10 quoted lines

> I noticed 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree
> by ensure-core-worktree, 2018-08-13) had two leftover debugging statements
> when reading The coverage report [1]. Remove them.
>
> https://public-inbox.org/git/e30a9c05-87d8-1f2b-182c-6d6a5fefe43c@gmail.com/
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  builtin/submodule--helper.c | 2 --
>  1 file changed, 2 deletions(-)

Doh.  Glad you caught it!

Is there some reference for The Coverage Report other than the mailing list? E.g. I suspect a reference to

	make coverage-test
	make coverage-report

would be useful to readers finding this commit later.

> To be applied on (or squashed into the tip of)
>   sb/submodule-update-in-c

Looks like that's already in "master", so not a candidate for squashing.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>