Re: [PATCH 1/1] subtree: make install targets depend on build targets

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 17, 2018, 02:45 UTC
Message-ID: <20181017024503.GA117170@aiede.svl.corp.google.com>
In-Reply-To: <20181016075624.30176-1-list@eworm.de>

Hi,

Christian Hesse wrote:

> --- a/contrib/subtree/Makefile
> +++ b/contrib/subtree/Makefile
> @@ -69,11 +69,11 @@ install: $(GIT_SUBTREE)

[...]

> -install-html: $(GIT_SUBTREE_HTML)
> +install-html: html

This broke the build for me:

 make[2]: Entering directory '/build/git-2.19.1+next.20181016/contrib/subtree'
 install -m 644 html /build/git-2.19.1+next.20181016/debian/tmp/usr/share/doc/git/html
 install: cannot stat 'html': No such file or directory
 make[2]: *** [Makefile:78: install-html] Error 1

The rule says

 install-html: html
	$(INSTALL) -d -m 755 $(DESTDIR)$(htmldir)
	$(INSTALL) -m 644 $^ $(DESTDIR)$(htmldir)

and $^ substitutes to "html" after this change. How was this patch tested?

Thanks, Jonathan