Re: What's cooking in git.git (Oct 2018, #02; Sat, 13)

From: Josh Steadmon <steadmon@google.com>
Date: Oct 16, 2018, 21:20 UTC
Message-ID: <20181016212008.GA249669@google.com>
In-Reply-To: <xmqqh8hr9pxb.fsf@gitster-ct.c.googlers.com>

On 2018.10.12 23:53, Junio C Hamano wrote:

Show 13 quoted lines

> * js/remote-archive-v2 (2018-09-28) 4 commits
>   (merged to 'next' on 2018-10-12 at 5f34377f60)
>  + archive: allow archive over HTTP(S) with proto v2
>  + archive: implement protocol v2 archive command
>  + archive: use packet_reader for communications
>  + archive: follow test standards around assertions
> 
>  The original implementation of "git archive --remote" more or less
>  bypassed the transport layer and did not work over http(s).  The
>  version 2 of the protocol is defined to allow going over http(s) as
>  well as Git native transport.
> 
>  Will merge to 'master'.

The first two patches (test cleanup and packet_reader refactor) are OK, but the latter two will break the archive command when an old client attempts to talk to a new server (due to the version advertisement problem noted in [1]). Sorry that I didn't catch that these had made it into next.

[1]: https://public-inbox.org/git/20180927223314.GA230445@google.com/#t