git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[Question] builtin/branch.c

From
Tao Qingyun <taoqy@ls-a.me>
Date
Oct 13, 2018, 08:11 UTC
Message-ID
<20181013081101.6602-1-taoqy@ls-a.me>

Hi, I am learning `builtin/branch.c`. I find that it will call `branch_get` before create and [un]set upstream, and die with "no such branch" if failed. but `branch_get` seems never fail, it is a get_or_create. Also, it was confused that getting a branch before it has created.

builtin/branch.c #811
    } else if (argc > 0 && argc <= 2) {
        struct branch *branch = branch_get(argv[0]);
        if (!branch)
            die(_("no such branch '%s'"), argv[0]);
        if (filter.kind != FILTER_REFS_BRANCHES)
            die(_("-a and -r options to 'git branch' do not make sense with a branch name"));
        if (track == BRANCH_TRACK_OVERRIDE)
            die(_("the '--set-upstream' option is no longer supported. Please use '--track' or '--set-upstream-to' instead."));
        create_branch(argv[0], (argc == 2) ? argv[1] : head,
                  force, 0, reflog, quiet, track);
Next: Ævar Arnfjörð Bjarmason
Message 1 of 8 in “[Question] builtin/branch.c”
  1. Tao QingyunOct 13, 2018
  2. Ævar Arnfjörð BjarmasonOct 14, 2018
  3. builtin/branch.c: remove useless branch_getTao Qingyun, Oct 15, 2018
  4. Jeff KingOct 15, 2018
  5. builtin/branch.c: remove useless branch_getTao Qingyun, Oct 16, 2018
  6. Jeff KingOct 17, 2018
  7. Tao QingyunOct 17, 2018
  8. Jeff KingOct 15, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.