git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] doc: move git-cherry to plumbing

From
Daniels Umanovskis <daniels@umanovskis.se>
Date
Oct 11, 2018, 18:33 UTC
Message-ID
<20181011183350.14584-1-daniels@umanovskis.se>

Also remove git-cherry from Bash completion because plumbing commands do not belong there.

Signed-off-by: Daniels Umanovskis <daniels@umanovskis.se>
---

Up to discussion whether cherry should be considered plumbing. I lean towards considering it a rarely-used porcelain command, but a case could be made either way so let's see what the list thinks.

 command-list.txt                       |  2 +-
 contrib/completion/git-completion.bash | 11 -----------
 2 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/command-list.txt b/command-list.txt
index c36ea3c18..bdca6e3d3 100644
--- a/command-list.txt
+++ b/command-list.txt
@@ -62,7 +62,7 @@ git-check-mailmap                       purehelpers
 git-checkout                            mainporcelain           history
 git-checkout-index                      plumbingmanipulators
 git-check-ref-format                    purehelpers
-git-cherry                              ancillaryinterrogators          complete
+git-cherry                              plumbinginterrogators          complete
 git-cherry-pick                         mainporcelain
 git-citool                              mainporcelain
 git-clean                               mainporcelain
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d63d2dffd..12f7ce0c5 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1340,17 +1340,6 @@ _git_checkout ()
 	esac
 }
 
-_git_cherry ()
-{
-	case "$cur" in
-	--*)
-		__gitcomp_builtin cherry
-		return
-	esac
-
-	__git_complete_refs
-}
-
 __git_cherry_pick_inprogress_options="--continue --quit --abort"
 
 _git_cherry_pick ()
-- 
2.19.1.330.g93276587c.dirty
Next: Duy Nguyen
Message 1 of 2 in “doc: move git-cherry to plumbing”
  1. doc: move git-cherry to plumbingDaniels Umanovskis, Oct 11, 2018
  2. Duy NguyenNov 1, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.