git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

From
AMAnanya Krishna Maram <ananyakittu1997@gmail.com>
Date
Oct 8, 2018, 17:05 UTC
Message-ID
<20181008170505.GA13134@manohar-ssh>

Hi All, I was searching through #leftovers and found this. https://public-inbox.org/git/CABPp-BGVVXcbZX44er6TO-PUsfEN_6GNYJ1U5cuoN9deaA48OQ@mail.gmail.com/

This patch address the task discussed in the above link. 
From: Ananya Krishan Maram <ananyakittu1997@gmail.com>
skip the #include of git-compat-util.h since all .c files include it.
Signed-off-by: Ananya Krishna Maram <ananyakittu1997@gmail.com>
---
 advice.h             | 1 -
 commit-graph.h       | 1 -
 hash.h               | 1 -
 pkt-line.h           | 1 -
 t/helper/test-tool.h | 1 -
 5 files changed, 5 deletions(-)
diff --git a/advice.h b/advice.h
index ab24df0fd..09148baa6 100644
--- a/advice.h
+++ b/advice.h
@@ -1,7 +1,6 @@
 #ifndef ADVICE_H
 #define ADVICE_H
 
-#include "git-compat-util.h"
 
 extern int advice_push_update_rejected;
 extern int advice_push_non_ff_current;
diff --git a/commit-graph.h b/commit-graph.h
index b05047676..0e93c2bed 100644
--- a/commit-graph.h
+++ b/commit-graph.h
@@ -1,7 +1,6 @@
 #ifndef COMMIT_GRAPH_H
 #define COMMIT_GRAPH_H
 
-#include "git-compat-util.h"
 #include "repository.h"
 #include "string-list.h"
 #include "cache.h"
diff --git a/hash.h b/hash.h
index 7c8238bc2..9a4334c5d 100644
--- a/hash.h
+++ b/hash.h
@@ -1,7 +1,6 @@
 #ifndef HASH_H
 #define HASH_H
 
-#include "git-compat-util.h"
 
 #if defined(SHA1_PPC)
 #include "ppc/sha1.h"
diff --git a/pkt-line.h b/pkt-line.h
index 5b28d4347..fdd316494 100644
--- a/pkt-line.h
+++ b/pkt-line.h
@@ -1,7 +1,6 @@
 #ifndef PKTLINE_H
 #define PKTLINE_H
 
-#include "git-compat-util.h"
 #include "strbuf.h"
 
 /*
diff --git a/t/helper/test-tool.h b/t/helper/test-tool.h
index e07495727..24e0a1589 100644
--- a/t/helper/test-tool.h
+++ b/t/helper/test-tool.h
@@ -1,7 +1,6 @@
 #ifndef __TEST_TOOL_H__
 #define __TEST_TOOL_H__
 
-#include "git-compat-util.h"
 
 int cmd__chmtime(int argc, const char **argv);
 int cmd__config(int argc, const char **argv);
-- 
2.19.0.272.ga00e0029e
Next: Derrick Stolee
Message 1 of 8 in “[Outreachy] remove all the inclusions of git-compat-util.h in header files”
  1. [Outreachy] remove all the inclusions of git-compat-util.h in header filesAnanya Krishna Maram, Oct 8, 2018
  2. Derrick StoleeOct 8, 2018
  3. Ananya Krishna MaramOct 9, 2018
  4. Junio C HamanoOct 9, 2018
  5. Johannes SchindelinOct 10, 2018
  6. Junio C HamanoOct 10, 2018
  7. Christian CouderOct 10, 2018
  8. Junio C HamanoOct 10, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.