Re: [PATCH] grep: provide a noop --recursive option
- From
- Mischa POSLAWSKY <git@shiar.nl>
- Date
- Oct 5, 2018, 13:05 UTC
- Message-ID
- <20181005130516.3qnhtjg7js53iomf@shiar.net>
- In-Reply-To
- <xmqqftxkztzb.fsf@gitster-ct.c.googlers.com>
Junio C Hamano wrote 2018-10-05 1:19 (-0700):
Show 14 quoted lines
> Stefan Beller <sbeller@google.com> writes: > > > git-grep is always file/tree recursive, but there is --recurse-submodules > > which is off by default. Instead of providing a short alias to a noop, > > we could use -r for submodules. (And if you happen to have no > > submodules, this is a noop for you) > > I am not sure if it is an overall win for those who do have and use > submodules to easily be able to go recursive with a short-and-sweet > 'r', or even they want to work inside one project at a time most of > the time. If the latter, then using 'r' for recurse-submodules is > going to be a mistake (besides, other commands that have 'recursive' > typically use 'r' for its shorthand,and 'r' does not stand for > 'recurse-submodules' for them).
Personally I would welcome a shorthand for --recurse-submodules, especially if --r^I no longer completes to this.
It is also closer to the behaviour provided by grep -r as that recurses into submodules as well.
Regards,
-- Mischa