git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] branch: trivial style fix

From
Tao Qingyun <taoqy@ls-a.me>
Date
Oct 5, 2018, 09:52 UTC
Message-ID
<20181005095213.12509-1-taoqy@ls-a.me>
---
 builtin/branch.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/branch.c b/builtin/branch.c
index c396c41533..52aad0f602 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -222,10 +222,11 @@ static int delete_branches(int argc, const char **argv, int force, int kinds,
 		if (!head_rev)
 			die(_("Couldn't look up commit object for HEAD"));
 	}
-	for (i = 0; i < argc; i++, strbuf_reset(&bname)) {
+	for (i = 0; i < argc; i++) {
 		char *target = NULL;
 		int flags = 0;
 
+		strbuf_reset(&bname);
 		strbuf_branchname(&bname, argv[i], allowed_interpret);
 		free(name);
 		name = mkpathdup(fmt, bname.buf);
@@ -716,8 +717,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
 		print_columns(&output, colopts, NULL);
 		string_list_clear(&output, 0);
 		return 0;
-	}
-	else if (edit_description) {
+	} else if (edit_description) {
 		const char *branch_name;
 		struct strbuf branch_ref = STRBUF_INIT;
 
-- 
2.19.0
Next: Jeff King
Message 1 of 9 in “branch: trivial style fix”
  1. branch: trivial style fixTao Qingyun, Oct 5, 2018
  2. Jeff KingOct 5, 2018
  3. Junio C HamanoOct 5, 2018
  4. branch: trivial style fixTao Qingyun, Oct 16, 2018
  5. Jeff KingOct 16, 2018
  6. Jeff KingOct 15, 2018
  7. Tao QingyunOct 16, 2018
  8. Ævar Arnfjörð BjarmasonOct 16, 2018
  9. Jeff KingOct 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.