Re: [PATCH v3 0/5] oidset: use khash

From: Jeff King <peff@peff.net>
Date: Oct 4, 2018, 22:15 UTC
Message-ID: <20181004221531.GC28287@sigill.intra.peff.net>
In-Reply-To: <14e57ec8-b8a2-10bd-688d-1cb926e77675@web.de>

On Thu, Oct 04, 2018 at 05:05:37PM +0200, René Scharfe wrote:

Show 16 quoted lines

> Two new patches to avoid using oidset internals in fetch-pack:
> 
>   fetch-pack: factor out is_unmatched_ref()
>   fetch-pack: load tip_oids eagerly iff needed
> 
> Unchanged patch:
> 
>   khash: factor out kh_release_*
> 
> Unchanged, except it doesn't touch fetch-pack anymore:
> 
>   oidset: use khash
> 
> A new patch, to reduce object text size:
> 
>   oidset: uninline oidset_init()

I left a few responses to the fetch-pack changes. The rest of it all looks good to me. Certainly it's satisfying for the implementation-swap in patch 4 to be able to touch _only_ oidset.[ch].

-Peff