git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config.txt: correct the note about uploadpack.packObjectsHook

From
Jeff King <peff@peff.net>
Date
Sep 29, 2018, 06:58 UTC
Message-ID
<20180929065849.GA2174@sigill.intra.peff.net>
In-Reply-To
<20180929065056.9960-1-pclouds@gmail.com>
On Sat, Sep 29, 2018 at 08:50:56AM +0200, Nguyễn Thái Ngọc Duy wrote:
Show 8 quoted lines
> Document for uploadpack.packObjectsHook is added in [1] and consists
> of two paragraphs, the second one is quite important about where this
> variable can stay.
> 
> When the paragraph about uploadpack.allowFilter is added in [2], it's
> added in between the two paragraphs. This makes the "this is non-repo
> level config" note incorrectly apply to allowFilter instead of
> packObjectsHook. Move allowFilter paragraph down to fix this.
Nice catch, and the patch looks obviously correct. Thanks.
-Peff
Previous: Nguyễn Thái Ngọc Duy
Message 2 of 2 in “config.txt: correct the note about uploadpack.packObjectsHook”
  1. config.txt: correct the note about uploadpack.packObjectsHookNguyễn Thái Ngọc Duy, Sep 29, 2018
  2. Jeff KingSep 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.