Re: [PATCH 2/3] archive: implement protocol v2 archive command

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 14, 2018, 05:39 UTC
Message-ID: <20180914053944.GB219147@aiede.svl.corp.google.com>
In-Reply-To: <20180912053519.31085-3-steadmon@google.com>

Hi,

Josh Steadmon wrote:

Show 13 quoted lines

> This adds a new archive command for protocol v2. The command expects
> arguments in the form "argument X" which are passed unmodified to
> git-upload-archive--writer.
>
> This command works over the file://, Git, and SSH transports. HTTP
> support will be added in a separate patch.
>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
> ---
>  builtin/archive.c        | 45 +++++++++++++++++++++++++++-------------
>  builtin/upload-archive.c | 44 ++++++++++++++++++++++++++++++++++++---
>  t/t5000-tar-tree.sh      |  5 +++++
>  3 files changed, 77 insertions(+), 17 deletions(-)

I like the diffstat. :)

Can this include some docs in Documentation/technical/ as well, to help other implementors to understand the protocol so they can interoperate?

Thanks, Jonathan