git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 00/10] use oidset for skiplist + docs + tests + comment support

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 3, 2018, 14:49 UTC
Message-ID
<20180903144928.30691-1-avarab@gmail.com>
In-Reply-To
<2b31e12e-20e9-3d08-58bd-977f8b83e0a7@web.de>
Addresses feedback René had on v4. Notes below:
René Scharfe (3):
  fsck: add a performance test for skipList
  fsck: use strbuf_getline() to read skiplist file
No changes.
  fsck: use oidset instead of oid_array for skipList

Now we note in the commit message that the skipList is re-consulted for .gitmodules blobs, as René pointed out.

Ævar Arnfjörð Bjarmason (7):
  fsck tests: setup of bogus commit object
  fsck tests: add a test for no skipList input
No changes.
  fsck: document and test sorted skipList input
Trivial whitespace change in new docs paragraph.
  fsck: document and test commented & empty line skipList input
No changes.
  fsck: document that skipList input must be unabbreviated
NEW: Now we document & test for the SHA-1s on the skip list being
unabbreviated. It was always like this, but let's say so / test for
it.
  fsck: add a performance test
NEW: Add a generic new fsck perf test while I'm at it, in addition to
the more specific one René wrote.
  fsck: support comments & empty lines in skipList

The major change this time around, we now support trailing comments, leading whitespace before comments, whitespace-only lines etc. I went one step further than what René suggested and decided to just call strbuf_trim() so now we also support SHA-1s with leading spaces. I don't see a good reason to go out of our way to ban those, and it's consistent with other formats we use (and perhaps people will use this to align them in some way).

 Documentation/config.txt        | 23 ++++++++---
 fsck.c                          | 60 +++++++++++++--------------
 fsck.h                          |  8 ++--
 t/perf/p1450-fsck.sh            | 13 ++++++
 t/perf/p1451-fsck-skip-list.sh  | 40 ++++++++++++++++++
 t/t5504-fetch-receive-strict.sh | 72 +++++++++++++++++++++++++++++++--
 6 files changed, 171 insertions(+), 45 deletions(-)
 create mode 100755 t/perf/p1450-fsck.sh
 create mode 100755 t/perf/p1451-fsck-skip-list.sh
-- 
2.19.0.rc1.350.ge57e33dbd1
Previous: René ScharfeNext: Ævar Arnfjörð Bjarmason
Message 19 of 32 in “use oidset for skiplist + docs + tests + comment support”
  1. 0/7 use oidset for skiplist + docs + tests + comment supportÆvar Arnfjörð Bjarmason, Aug 27, 2018
  2. 1/7 fsck tests: setup of bogus commit objectÆvar Arnfjörð Bjarmason, Aug 27, 2018
  3. 2/7 fsck tests: add a test for no skipList inputÆvar Arnfjörð Bjarmason, Aug 27, 2018
  4. 3/7 fsck: document and test sorted skipList inputÆvar Arnfjörð Bjarmason, Aug 27, 2018
  5. 4/7 fsck: document and test commented & empty line skipList inputÆvar Arnfjörð Bjarmason, Aug 27, 2018
  6. 5/7 fsck: use strbuf_getline() to read skiplist fileÆvar Arnfjörð Bjarmason, Aug 27, 2018
  7. 6/7 fsck: use oidset for skiplistÆvar Arnfjörð Bjarmason, Aug 27, 2018
  8. Ævar Arnfjörð BjarmasonAug 27, 2018
  9. 1/8 fsck tests: setup of bogus commit objectÆvar Arnfjörð Bjarmason, Aug 28, 2018
  10. 0/8 use oidset for skiplist + docs + tests + comment supportÆvar Arnfjörð Bjarmason, Aug 28, 2018
  11. 2/8 fsck tests: add a test for no skipList inputÆvar Arnfjörð Bjarmason, Aug 28, 2018
  12. 3/8 fsck: document and test sorted skipList inputÆvar Arnfjörð Bjarmason, Aug 28, 2018
  13. 4/8 fsck: document and test commented & empty line skipList inputÆvar Arnfjörð Bjarmason, Aug 28, 2018
  14. 5/8 fsck: add a performance test for skipListÆvar Arnfjörð Bjarmason, Aug 28, 2018
  15. 6/8 fsck: use strbuf_getline() to read skiplist fileÆvar Arnfjörð Bjarmason, Aug 28, 2018
  16. 7/8 fsck: use oidset instead of oid_array for skipListÆvar Arnfjörð Bjarmason, Aug 28, 2018
  17. 8/8 fsck: support comments & empty lines in skipListÆvar Arnfjörð Bjarmason, Aug 28, 2018
  18. René ScharfeAug 28, 2018
  19. 00/10 use oidset for skiplist + docs + tests + comment supportÆvar Arnfjörð Bjarmason, Sep 3, 2018
  20. 01/10 fsck tests: setup of bogus commit objectÆvar Arnfjörð Bjarmason, Sep 3, 2018
  21. 02/10 fsck tests: add a test for no skipList inputÆvar Arnfjörð Bjarmason, Sep 3, 2018
  22. 03/10 fsck: document and test sorted skipList inputÆvar Arnfjörð Bjarmason, Sep 3, 2018
  23. 04/10 fsck: document and test commented & empty line skipList inputÆvar Arnfjörð Bjarmason, Sep 3, 2018
  24. 05/10 fsck: document that skipList input must be unabbreviatedÆvar Arnfjörð Bjarmason, Sep 3, 2018
  25. 06/10 fsck: add a performance testÆvar Arnfjörð Bjarmason, Sep 3, 2018
  26. 08/10 fsck: use strbuf_getline() to read skiplist fileÆvar Arnfjörð Bjarmason, Sep 3, 2018
  27. 09/10 fsck: use oidset instead of oid_array for skipListÆvar Arnfjörð Bjarmason, Sep 3, 2018
  28. 10/10 fsck: support comments & empty lines in skipListÆvar Arnfjörð Bjarmason, Sep 3, 2018
  29. 07/10 fsck: add a performance test for skipListÆvar Arnfjörð Bjarmason, Sep 3, 2018
  30. René ScharfeAug 28, 2018
  31. 7/7 fsck: support comments & empty lines in skipListÆvar Arnfjörð Bjarmason, Aug 27, 2018
  32. Ævar Arnfjörð BjarmasonAug 27, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.