Re: Feature request: hooks directory

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 31, 2018, 03:16 UTC
Message-ID: <20180831031654.GB98946@aiede.svl.corp.google.com>
In-Reply-To: <87pnxzdib7.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> There is interest in this. This E-Mail of mine gives a good summary of
> prior discussions about this:
> https://public-inbox.org/git/877eqqnq22.fsf@evledraar.gmail.com/
>
> I.e. it's something I've personally been interested in doing in the
> past, there's various bolt-on solutions to do it (basically local hook
> runners) used by various projects.

A few unrelated thoughts, to expand on this.

Reports of experience from using local hook runners would be very welcome so we can benefit from their good ideas and avoid their bad ones. That was part of the motivation for not building this in for so long: we want people to experiment so that the result can be something that works well for a lot of people.

Separately from that, in [1] I mentioned that I want to revamp how hooks work somewhat, to avoid the attack described there (or the more common attack also described there that involves a zip file). Such a revamp would be likely to also handle this multiple-hook use case.

As a word of caution, today we support having multiple credential helpers in use and it's a nightmare to support. The layering model is complicated and users don't understand it. So we might want to try to avoid whatever went wrong there. ;-)

Thanks, Jonathan

[1] https://public-inbox.org/git/20171002234517.GV19555@aiede.mtv.corp.google.com/