git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 07/11] t1006: make hash size independent

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Aug 29, 2018, 00:56 UTC
Message-ID
<20180829005642.980617-8-sandals@crustytoothpaste.net>
In-Reply-To
<20180829005642.980617-1-sandals@crustytoothpaste.net>

Compute the size of the tree and commit objects we're creating by checking for the size of an object ID and computing the resulting sizes accordingly.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t1006-cat-file.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
index 7f19d591f2..a7c95bb785 100755
--- a/t/t1006-cat-file.sh
+++ b/t/t1006-cat-file.sh
@@ -140,15 +140,17 @@ test_expect_success '--batch-check without %(rest) considers whole line' '
 	test_cmp expect actual
 '
 
+test_oid_init
+
 tree_sha1=$(git write-tree)
-tree_size=33
+tree_size=$(($(test_oid rawsz) + 13))
 tree_pretty_content="100644 blob $hello_sha1	hello"
 
 run_tests 'tree' $tree_sha1 $tree_size "" "$tree_pretty_content"
 
 commit_message="Initial commit"
 commit_sha1=$(echo_without_newline "$commit_message" | git commit-tree $tree_sha1)
-commit_size=177
+commit_size=$(($(test_oid hexsz) + 137))
 commit_content="tree $tree_sha1
 author $GIT_AUTHOR_NAME <$GIT_AUTHOR_EMAIL> 0000000000 +0000
 committer $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 0000000000 +0000
Previous: brian m. carlsonNext: brian m. carlson
Message 14 of 19 in “Hash-independent tests (part 3)”
  1. 00/11 Hash-independent tests (part 3)brian m. carlson, Aug 29, 2018
  2. 01/11 t: add tool to translate hash-related valuesbrian m. carlson, Aug 29, 2018
  3. Jonathan NiederAug 29, 2018
  4. brian m. carlsonAug 29, 2018
  5. Derrick StoleeAug 29, 2018
  6. brian m. carlsonAug 29, 2018
  7. 02/11 t0000: use hash translation tablebrian m. carlson, Aug 29, 2018
  8. 03/11 t0000: update tests for SHA-256brian m. carlson, Aug 29, 2018
  9. 05/11 t0027: make hash size independentbrian m. carlson, Aug 29, 2018
  10. Torsten BögershausenAug 31, 2018
  11. Eric SunshineAug 31, 2018
  12. brian m. carlsonSep 1, 2018
  13. 04/11 t0002: abstract away SHA-1 specific constantsbrian m. carlson, Aug 29, 2018
  14. 07/11 t1006: make hash size independentbrian m. carlson, Aug 29, 2018
  15. 06/11 t0064: make hash size independentbrian m. carlson, Aug 29, 2018
  16. 08/11 t1400: switch hard-coded object ID to variablebrian m. carlson, Aug 29, 2018
  17. 09/11 t1405: make hash size independentbrian m. carlson, Aug 29, 2018
  18. 10/11 t1406: make hash-size independentbrian m. carlson, Aug 29, 2018
  19. 11/11 t1407: make hash size independentbrian m. carlson, Aug 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.