Re: [ANNOUNCE] Git v2.19.0-rc0
- From
Jeff King <peff@peff.net>
- Date
- Aug 22, 2018, 15:17 UTC
- Message-ID
- <20180822151703.GB32630@sigill.intra.peff.net>
- In-Reply-To
- <d1fafc75-d6e4-d363-d600-579c200aca43@gmail.com>
On Wed, Aug 22, 2018 at 07:14:42AM -0400, Derrick Stolee wrote:
> The other thing I was going to recommend (and I'll try to test this out > myself later) is to see if 'the_hash_algo->rawsz' is being treated as a > volatile variable, since it is being referenced through a pointer. Perhaps > storing the value locally and then casing on it would help?
I tried various sprinkling of "const" around the declarations to make it clear that the values wouldn't change once we saw them. But I couldn't detect any difference. At most I think that would let us hoist the "if" out of the loop, but gcc still seems unwilling to expand the memcmp when there are other branches.
I think if that's the thing we want to have happen, we really do need to just write it out on that branch rather than saying "memcmp".
-Peff