Re: [PATCH v1 02/25] structured-logging: add STRUCTURED_LOGGING=1 to Makefile

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 21, 2018, 04:49 UTC
Message-ID: <20180821044954.GB219616@aiede.svl.corp.google.com>
In-Reply-To: <20180713165621.52017-3-git@jeffhostetler.com>

git@jeffhostetler.com wrote:

Show 13 quoted lines

> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> Teach the Makefile to take STRUCTURED_LOGGING=1 variable to
> compile in/out structured logging feature.
>
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
> ---
>  Makefile             |  8 ++++++++
>  structured-logging.c |  9 +++++++++
>  structured-logging.h | 13 +++++++++++++
>  3 files changed, 30 insertions(+)
>  create mode 100644 structured-logging.c
>  create mode 100644 structured-logging.h

This should probably be squashed with a later patch (e.g., patch 3). When taken alone, it produces

[...]

Show 12 quoted lines

> --- /dev/null
> +++ b/structured-logging.c
> @@ -0,0 +1,9 @@
> +#if !defined(STRUCTURED_LOGGING)
> +/*
> + * Structured logging is not available.
> + * Stub out all API routines.
> + */
> +
> +#else
> +
> +#endif

which is not idiomatic (for example, it's missing a #include of git-compat-util.h, etc).

Thanks, Jonathan