Re: [RFC/PATCH] drop vcs-svn experiment

From: Todd Zullinger <tmz@pobox.com>
Date: Aug 17, 2018, 19:33 UTC
Message-ID: <20180817193347.GL24629@zaya.teonanacatl.net>
In-Reply-To: <20180817190310.GA5360@sigill.intra.peff.net>

Hi Jeff,

Jeff King wrote:

Show 11 quoted lines

>  .gitignore                     |   1 -
>  Makefile                       |  22 --
>  contrib/svn-fe/.gitignore      |   4 -
>  contrib/svn-fe/Makefile        | 105 -------
>  contrib/svn-fe/svn-fe.c        |  18 --
>  contrib/svn-fe/svn-fe.txt      |  71 -----
>  contrib/svn-fe/svnrdump_sim.py |  68 -----
>  remote-testsvn.c               | 337 --------------------
>  t/helper/test-line-buffer.c    |  81 -----
>  t/helper/test-svn-fe.c         |  52 ----
>  t/t9020-remote-svn.sh          |  89 ------

Doesn't t/t9010-svn-fe.sh also need to be removed? It uses the test-svn-fe helper which is removed.

The Fedora git-svn package has included git-remote-testsvn for years now but no one has ever filed any bug reports about it. I looked at whether it should be packaged last year. I came to the conclusion that while it could be used outside of the test suite it was doubtful it actually was.

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
No one ever went broke underestimating the taste of the American
public.
    -- H. L. Mencken