Re: [PATCH] refactor various if (x) FREE_AND_NULL(x) to just FREE_AND_NULL(x)

From: Jeff King <peff@peff.net>
Date: Aug 17, 2018, 17:44 UTC
Message-ID: <20180817174404.GB9474@sigill.intra.peff.net>
In-Reply-To: <20180817173951.GA9474@sigill.intra.peff.net>

On Fri, Aug 17, 2018 at 01:39:51PM -0400, Jeff King wrote:

Show 11 quoted lines

> > I wonder if there is a way to "relax" a pattern where these semantically
> > equivalent cases can all be covered automatically. I don't know enough
> > about the tool to say.
> 
> Hmm. They seem to call these "standard isomorphisms":
> 
>   http://coccinelle.lip6.fr/standard.iso.html
> 
> but I'm not sure of the correct way to use them (e.g., if we want to
> apply them for matching but not actually transform the code, though I am
> not actually opposed to transforming the code, too).

Hmph, I should really pause before hitting 'send'. Last message, I promise. :)

I do not see an option to include a list an arbitrary set of isomorphisms, but the standard.iso list should be used by default. I wonder if you simply need to write your case in the normalized version they use there (which I think is "X == NULL"), and the others would be taken care of.

-Peff