git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC] commit: add short option for --amend

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Aug 16, 2018, 18:31 UTC
Message-ID
<20180816183117.13716-1-pclouds@gmail.com>

I just realized how often I type "git ci --amend". Looking back at my ~/.bash_history (only 10k lines) this is the second most often git command I type which may justify a short option for it (assuming that other people use this option often too, of course).

The short option space for 'git commit' is really crowded with acCeFhimnopqsStuvz already taken. So it could be '-M' or '-A' but I'd prefer not to hold shift, so I chose '-j' even though it's not strictly related to "amend" (or perhaps we can thinking of amending as joining commits).

Thoughts?
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 213fca2d8e..78f125ba1f 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1489,7 +1489,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix)
 			    STATUS_FORMAT_LONG),
 		OPT_BOOL('z', "null", &s.null_termination,
 			 N_("terminate entries with NUL")),
-		OPT_BOOL(0, "amend", &amend, N_("amend previous commit")),
+		OPT_BOOL('j', "amend", &amend, N_("amend previous commit")),
 		OPT_BOOL(0, "no-post-rewrite", &no_post_rewrite, N_("bypass post-rewrite hook")),
 		{ OPTION_STRING, 'u', "untracked-files", &untracked_files_arg, N_("mode"), N_("show untracked files, optional modes: all, normal, no. (Default: all)"), PARSE_OPT_OPTARG, NULL, (intptr_t)"all" },
 		/* end commit contents options */
-- 
2.18.0.1004.g6639190530
Next: Jeff King
Message 1 of 9 in “commit: add short option for --amend”
  1. commit: add short option for --amendNguyễn Thái Ngọc Duy, Aug 16, 2018
  2. Jeff KingAug 16, 2018
  3. Duy NguyenAug 16, 2018
  4. Jonathan NiederAug 17, 2018
  5. Duy NguyenAug 17, 2018
  6. Jeff KingAug 17, 2018
  7. Duy NguyenAug 17, 2018
  8. Junio C HamanoAug 17, 2018
  9. Simon RuderichAug 18, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.