[PATCH 1/4] cat-file: use oidset check-and-insert
- From
Jeff King <peff@peff.net>
- Date
- Aug 14, 2018, 18:14 UTC
- Message-ID
- <20180814181427.GA26919@sigill.intra.peff.net>
- In-Reply-To
- <20180814181358.GA26391@sigill.intra.peff.net>
We don't need to check if the oidset has our object before we insert it; that's done as part of the insertion. We can just rely on the return value from oidset_insert(), which saves one hash lookup per object.
This measurable speedup is tiny and within the run-to-run noise, but the result is simpler to read, too.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/cat-file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/builtin/cat-file.c b/builtin/cat-file.c index 45992c9be9..04b5cda191 100644 --- a/builtin/cat-file.c +++ b/builtin/cat-file.c @@ -443,9 +443,8 @@ static int batch_unordered_object(const struct object_id *oid, void *vdata) { struct object_cb_data *data = vdata; - if (oidset_contains(data->seen, oid)) + if (oidset_insert(data->seen, oid)) return 0; - oidset_insert(data->seen, oid); return batch_object_cb(oid, data); }
-- 2.18.0.1066.g0d97f3a098