Re: [RFC PATCH] packfile: iterate packed objects in pack order

From: Jeff King <peff@peff.net>
Date: Aug 10, 2018, 22:59 UTC
Message-ID: <20180810225918.GA18913@sigill.intra.peff.net>
In-Reply-To: <CAGf8dgK_yMEtyh+_chQ+9i2d1Uc9oAXr7Q_8ES5OPF8qF87EHw@mail.gmail.com>

On Thu, Aug 09, 2018 at 03:03:24PM -0700, Jonathan Tan wrote:

Show 13 quoted lines

> On Wed, Aug 8, 2018 at 4:25 PM, Jeff King <peff@peff.net> wrote:
> > Even if you just use the oid to do a separate lookup in the object
> > database, there's still a benefit in accessing the objects in pack
> > order.
> 
> You're probably right, but I don't immediately see what the benefit is.
> 
> On a not completely unrelated note, I just realized that in my patch,
> i should be pack_nr (ordinal in pack order) and pack_nr should be
> index_nr (ordinal in index order, i.e. alphabetical order). If you run
> with this, feel free to write your own patch and maybe I'll learn how
> accessing objects in pack order benefits looking up the object
> database through the commit message.

It probably would have been more apparent if when I said "like in the patch below" I actually remembered to paste in the patch. ;)

> > I can try to pick this up and carry the cat-file bits to completion if
> > you want, but probably not until tomorrow or Friday.
> 
> Thanks - feel free to do this.

I've got a series which I'll post momentarily which hopefully explains what's going on, along with various timings.

-Peff