git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 02/10] string-list.h: add string_list_pop function.

From
Stefan Beller <sbeller@google.com>
Date
Aug 8, 2018, 22:17 UTC
Message-ID
<20180808221752.195419-3-sbeller@google.com>
In-Reply-To
<20180808221752.195419-1-sbeller@google.com>

A string list can be used as a stack, but should we? A later patch shows how useful this will be.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 string-list.c | 8 ++++++++
 string-list.h | 6 ++++++
 2 files changed, 14 insertions(+)
diff --git a/string-list.c b/string-list.c
index 9f651bb4294..ea80afc8a0c 100644
--- a/string-list.c
+++ b/string-list.c
@@ -80,6 +80,14 @@ void string_list_remove(struct string_list *list, const char *string,
 	}
 }
 
+struct string_list_item *string_list_pop(struct string_list *list)
+{
+	if (list->nr == 0)
+		return 0;
+
+	return &list->items[--list->nr];
+}
+
 int string_list_has_string(const struct string_list *list, const char *string)
 {
 	int exact_match;
diff --git a/string-list.h b/string-list.h
index ff8f6094a33..a1a41bc961a 100644
--- a/string-list.h
+++ b/string-list.h
@@ -191,6 +191,12 @@ extern void string_list_remove(struct string_list *list, const char *string,
  */
 struct string_list_item *string_list_lookup(struct string_list *list, const char *string);
 
+/**
+ * Returns the last item inserted and removes it from the list.
+ * If the list is empty, return NULL.
+ */
+struct string_list_item *string_list_pop(struct string_list *list);
+
 /*
  * Remove all but the first of consecutive entries with the same
  * string value.  If free_util is true, call free() on the util
-- 
2.18.0.597.ga71716f1ad-goog
Previous: Stefan BellerNext: Martin Ågren
Message 5 of 27 in “fetch: make sure submodule oids are fetched”
  1. 00/10 fetch: make sure submodule oids are fetchedStefan Beller, Aug 8, 2018
  2. 01/10 string_list: print_string_list to use trace_printfStefan Beller, Aug 8, 2018
  3. Junio C HamanoAug 9, 2018
  4. Stefan BellerAug 9, 2018
  5. 02/10 string-list.h: add string_list_pop function.Stefan Beller, Aug 8, 2018
  6. Martin ÅgrenAug 9, 2018
  7. Junio C HamanoAug 9, 2018
  8. Jeff KingAug 9, 2018
  9. Stefan BellerAug 9, 2018
  10. Jeff KingAug 9, 2018
  11. Stefan BellerAug 9, 2018
  12. 03/10 sha1-array: provide oid_array_remove_ifStefan Beller, Aug 8, 2018
  13. Martin ÅgrenAug 9, 2018
  14. Stefan BellerAug 9, 2018
  15. Jeff KingAug 9, 2018
  16. Junio C HamanoAug 9, 2018
  17. Junio C HamanoAug 9, 2018
  18. 04/10 submodule.c: convert submodule_move_head new argument to object idStefan Beller, Aug 8, 2018
  19. Junio C HamanoAug 9, 2018
  20. 05/10 submodule.c: fix indentationStefan Beller, Aug 8, 2018
  21. 06/10 submodule.c: sort changed_submodule_names before searching itStefan Beller, Aug 8, 2018
  22. 07/10 submodule: move global changed_submodule_names into fetch submodule structStefan Beller, Aug 8, 2018
  23. 08/10 submodule.c: do not copy around submodule listStefan Beller, Aug 8, 2018
  24. 09/10 submodule: fetch in submodules git directory instead of in worktreeStefan Beller, Aug 8, 2018
  25. 10/10 fetch: retry fetching submodules if sha1 were not fetchedStefan Beller, Aug 8, 2018
  26. Martin ÅgrenAug 9, 2018
  27. Stefan BellerAug 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.