git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git-instaweb: support Fedora/Red Hat apache module path

From
Sebastian Kisela <skisela@redhat.com>
Date
Aug 8, 2018, 08:49 UTC
Message-ID
<20180808084918.3424-2-skisela@redhat.com>
In-Reply-To
<20180808084918.3424-1-skisela@redhat.com>

On Fedora-derived systems, the apache httpd package installs modules under /usr/lib{,64}/httpd/modules, depending on whether the system is 32- or 64-bit. A symlink from /etc/httpd/modules is created which points to the proper module path. Use it to support apache on Fedora, CentOS, and Red Hat systems.

Written with assistance of Todd Zullinger <tmz@pobox.com> and Junio C Hamano <gitster@pobox.com>.

Signed-off-by: Sebastian Kisela <skisela@redhat.com>
---
 git-instaweb.sh | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 47e38f34c..675add184 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -326,13 +326,17 @@ EOF
 }
 
 apache2_conf () {
-	if test -z "$module_path"
-	then
-		test -d "/usr/lib/httpd/modules" &&
-			module_path="/usr/lib/httpd/modules"
-		test -d "/usr/lib/apache2/modules" &&
-			module_path="/usr/lib/apache2/modules"
-	fi
+	for candidate in \
+		/etc/httpd \
+		/usr/lib/apache2 \
+		/usr/lib/httpd ;
+	do
+		if test -d "$candidate/modules"
+		then
+			module_path="$candidate/modules"
+			break
+		fi
+	done
 	bind=
 	test x"$local" = xtrue && bind='127.0.0.1:'
 	echo 'text/css css' > "$fqgitdir/mime.types"
-- 
2.14.4
Previous: Sebastian Kisela
Message 6 of 6 in “git-instaweb: support Fedora/Red Hat apache module path”
  1. 1/2 git-instaweb: support Fedora/Red Hat apache module pathSebastian Kisela, Aug 7, 2018
  2. 2/2 git-instaweb: fix apache2 config with apache >= 2.4Sebastian Kisela, Aug 7, 2018
  3. Junio C HamanoAug 7, 2018
  4. Junio C HamanoAug 7, 2018
  5. 1/2 git-instaweb: support Fedora/Red Hat apache module pathSebastian Kisela, Aug 8, 2018
  6. 1/2 git-instaweb: support Fedora/Red Hat apache module pathSebastian Kisela, Aug 8, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.