git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/6] packfile: make get_delta_base() non static

From
Christian Couder <christian.couder@gmail.com>
Date
Aug 5, 2018, 17:25 UTC
Message-ID
<20180805172525.15278-2-chriscool@tuxfamily.org>
In-Reply-To
<20180805172525.15278-1-chriscool@tuxfamily.org>
From: Jeff King <peff@peff.net>

As get_delta_base() will be used outside 'packfile.c' in a following commit, let's make it non static and let's declare it in 'packfile.h'.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 packfile.c | 10 +++++-----
 packfile.h |  7 +++++++
 2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/packfile.c b/packfile.c
index 7cd45aa4b2..4646bff5ff 100644
--- a/packfile.c
+++ b/packfile.c
@@ -1037,11 +1037,11 @@ const struct packed_git *has_packed_and_bad(const unsigned char *sha1)
 	return NULL;
 }
 
-static off_t get_delta_base(struct packed_git *p,
-				    struct pack_window **w_curs,
-				    off_t *curpos,
-				    enum object_type type,
-				    off_t delta_obj_offset)
+off_t get_delta_base(struct packed_git *p,
+		     struct pack_window **w_curs,
+		     off_t *curpos,
+		     enum object_type type,
+		     off_t delta_obj_offset)
 {
 	unsigned char *base_info = use_pack(p, w_curs, *curpos, NULL);
 	off_t base_offset;
diff --git a/packfile.h b/packfile.h
index cc7eaffe1b..1265fd9b06 100644
--- a/packfile.h
+++ b/packfile.h
@@ -126,6 +126,13 @@ extern unsigned long unpack_object_header_buffer(const unsigned char *buf, unsig
 extern unsigned long get_size_from_delta(struct packed_git *, struct pack_window **, off_t);
 extern int unpack_object_header(struct packed_git *, struct pack_window **, off_t *, unsigned long *);
 
+/*
+ * Return the offset of the object that is the delta base of the object at curpos.
+ */
+extern off_t get_delta_base(struct packed_git *p, struct pack_window **w_curs,
+			    off_t *curpos, enum object_type type,
+			    off_t delta_obj_offset);
+
 extern void release_pack_memory(size_t);
 
 /* global flag to enable extra checks when accessing packed objects */
-- 
2.18.0.327.ga7d188ab43
Previous: Christian CouderNext: Christian Couder
Message 2 of 7 in “Add delta islands support”
  1. 0/6 Add delta islands supportChristian Couder, Aug 5, 2018
  2. 1/6 packfile: make get_delta_base() non staticChristian Couder, Aug 5, 2018
  3. 2/6 Add delta-islands.{c,h}Christian Couder, Aug 5, 2018
  4. 3/6 pack-objects: add delta-islands supportChristian Couder, Aug 5, 2018
  5. 4/6 repack: add delta-islands supportChristian Couder, Aug 5, 2018
  6. 5/6 t: add t5319-delta-islands.shChristian Couder, Aug 5, 2018
  7. 6/6 pack-objects: move tree_depth into 'struct packing_data'Christian Couder, Aug 5, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.