git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin/config.c: separate message and value by colon in error messages

From
Ralf Thielow <ralf.thielow@gmail.com>
Date
Aug 3, 2018, 16:50 UTC
Message-ID
<20180803165035.15099-1-ralf.thielow@gmail.com>

The error message and the value that caused that error should be separated by a colon.

Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
---
 builtin/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/config.c b/builtin/config.c
index 2c93a289a7..862f870b58 100644
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -98,7 +98,7 @@ static int option_parse_type(const struct option *opt, const char *arg,
 		else if (!strcmp(arg, "color"))
 			new_type = TYPE_COLOR;
 		else
-			die(_("unrecognized --type argument, %s"), arg);
+			die(_("unrecognized --type argument: %s"), arg);
 	}
 
 	to_type = opt->value;
-- 
2.18.0.203.gfac676dfb9
Message 1 of 1 in “builtin/config.c: separate message and value by colon in error messages”
  1. builtin/config.c: separate message and value by colon in error messagesRalf Thielow, Aug 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.