Re: Question regarding quarantine environments

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 3, 2018, 02:49 UTC
Message-ID: <20180803024902.GC197924@aiede.svl.corp.google.com>
In-Reply-To: <20180802183924.GB23690@sigill.intra.peff.net>

Hi,

Jeff King wrote:

> On Thu, Aug 02, 2018 at 12:58:52PM -0500, Liam Decker wrote:

Show 11 quoted lines

>> The solution that I implemented was to check the objects directory for the
>> object, and if it was not there, to look for a quarantine directory and try
>> there. However, that feels fairly inefficient.
>
> That's more or less what Git will do under the hood (though in the
> opposite order).
>
>> For the curious, the library and solution I attempted are both here [5]
>
> Just skimming, but it sounds like go-git does not support the
> GIT_OBJECT_DIRECTORY environment variable.

To be clear: we don't guarantee that the quarantine directory in the future will be where it is today.

So as Peff hinted, supporting GIT_OBJECT_DIRECTORY in go-git is likely to be the best way forward for your tool.

Thanks and hope that helps, Jonathan