git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] mw-to-git/t9360: fix broken &&-chain

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 30, 2018, 20:46 UTC
Message-ID
<20180730204646.32312-1-sunshine@sunshineco.com>
In-Reply-To
<https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google.com/>
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---

Jonathan's discovery[1] of a broken &&-chain in a contrib/subtree test prompted me to check other tests bundled in contrib/. This was the only other problem found. Unlike the subtree &&-chain case, this breakage is at the top-level, thus was caught by the normal --chain-lint mechanism, not the subshell linter.

[1]: https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google. com/

 contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
index 22f069db48..cfbfe7ddf6 100755
--- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
+++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
@@ -247,7 +247,7 @@ test_expect_success 'Test of resistance to modification of category on wiki for
 	wiki_editpage Notconsidered "this page will not appear on local" false &&
 	wiki_editpage Othercategory "this page will not appear on local" false -c=Cattwo &&
 	wiki_editpage Tobeedited "this page have been modified" true -c=Catone &&
-	wiki_delete_page Tobedeleted
+	wiki_delete_page Tobedeleted &&
 	git clone -c remote.origin.categories="Catone" \
 		mediawiki::'"$WIKI_URL"' mw_dir_14 &&
 	wiki_getallpage ref_page_14 Catone &&
-- 
2.18.0.597.ga71716f1ad
Next: Jonathan Nieder
Message 1 of 6 in “mw-to-git/t9360: fix broken &&-chain”
  1. mw-to-git/t9360: fix broken &&-chainEric Sunshine, Jul 30, 2018
  2. Jonathan NiederJul 30, 2018
  3. Matthieu MoyAug 8, 2018
  4. Antoine BeaupréAug 21, 2018
  5. Eric SunshineAug 21, 2018
  6. Antoine BeaupréAug 21, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.