git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/2] t3507: add a testcase showing failure with sparse checkout

From
Ben Peart <ben.peart@microsoft.com>
Date
Jul 27, 2018, 12:59 UTC
Message-ID
<20180727125923.11744-2-benpeart@microsoft.com>
In-Reply-To
<20180727125923.11744-1-benpeart@microsoft.com>
From: Ben Peart <peartben@gmail.com>

Recent changes in merge_content() induced a bug when merging files that are not present in the local working directory due to sparse-checkout. Add a test case to demonstrate the bug so that we can ensure the fix resolves it and to prevent future regressions.

Signed-off-by: Ben Peart <benpeart@microsoft.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
---
 t/t3507-cherry-pick-conflict.sh | 13 +++++++++++++
 1 file changed, 13 insertions(+)
diff --git a/t/t3507-cherry-pick-conflict.sh b/t/t3507-cherry-pick-conflict.sh
index 7c5ad08626..45ddd81bfa 100755
--- a/t/t3507-cherry-pick-conflict.sh
+++ b/t/t3507-cherry-pick-conflict.sh
@@ -392,4 +392,17 @@ test_expect_success 'commit --amend -s places the sign-off at the right place' '
 	test_cmp expect actual
 '
 
+test_expect_failure 'cherry-pick preserves sparse-checkout' '
+	pristine_detach initial &&
+	test_config core.sparseCheckout true &&
+	test_when_finished "
+		echo \"/*\" >.git/info/sparse-checkout
+		git read-tree --reset -u HEAD
+		rm .git/info/sparse-checkout" &&
+	echo /unrelated >.git/info/sparse-checkout &&
+	git read-tree --reset -u HEAD &&
+	test_must_fail git cherry-pick -Xours picked>actual &&
+	test_i18ngrep ! "Changes not staged for commit:" actual
+'
+
 test_done
-- 
2.17.0.gvfs.1.123.g449c066
Previous: Ben PeartNext: Ben Peart
Message 19 of 22 in “[BUG] merge-recursive overly aggressive when skipping updating the working tree”
  1. Ben PeartJul 20, 2018
  2. Elijah NewrenJul 20, 2018
  3. Junio C HamanoJul 20, 2018
  4. Elijah NewrenJul 20, 2018
  5. Junio C HamanoJul 20, 2018
  6. Elijah NewrenJul 20, 2018
  7. Ben PeartJul 23, 2018
  8. 0/2 Preserve skip_worktree bit in merges when necessaryElijah Newren, Jul 21, 2018
  9. 1/2 t3507: add a testcase showing failure with sparse checkoutElijah Newren, Jul 21, 2018
  10. Eric SunshineJul 21, 2018
  11. Ben PeartJul 23, 2018
  12. Eric SunshineJul 23, 2018
  13. Ben PeartJul 23, 2018
  14. Ben PeartJul 21, 2018
  15. Junio C HamanoJul 23, 2018
  16. 2/2 merge-recursive: preserve skip_worktree bit when necessaryElijah Newren, Jul 21, 2018
  17. Ben PeartJul 23, 2018
  18. 0/2 Preserve skip_worktree bit in merges when necessaryBen Peart, Jul 27, 2018
  19. 1/2 t3507: add a testcase showing failure with sparse checkoutBen Peart, Jul 27, 2018
  20. 2/2 merge-recursive: preserve skip_worktree bit when necessaryBen Peart, Jul 27, 2018
  21. Junio C HamanoJul 27, 2018
  22. Elijah NewrenJul 31, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.