git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jul 2018, #02; Wed, 18)

From
BWBrandon Williams <bmwill@google.com>
Date
Jul 24, 2018, 19:38 UTC
Message-ID
<20180724193836.GD225275@google.com>
In-Reply-To
<xmqqd0vcxwfu.fsf@gitster-ct.c.googlers.com>
On 07/24, Junio C Hamano wrote:
Show 27 quoted lines
> Jonathan Tan <jonathantanmy@google.com> writes:
> 
> >> Here are the topics that have been cooking.  Commits prefixed with
> >> '-' are only in 'pu' (proposed updates) while commits prefixed with
> >> '+' are in 'next'.  The ones marked with '.' do not appear in any of
> >> the integration branches, but I am still holding onto them.
> >
> > What do you think about my fixes to protocol v2 tag following [1]? There
> > was some discussion about correctness vs the drop in performance, but it
> > seems to me that there is some consensus that the drop in performance is
> > OK.
> >
> > [1] https://public-inbox.org/git/cover.1528234587.git.jonathantanmy@google.com/
> 
> Thanks for reminding.  I think I was waiting for Brandon or somebody
> else to say something after [2] as the final confirmation before
> queuing it, and then the thread was forgotten ;-)
> 
> Will pick it up; it seems to have some interaction with Brandon's
> 6d1700d5 ("fetch: refactor to make function args narrower",
> 2018-06-27), and I think the correct resolution is to move your
> removal of "&& !rs->nr" to do_fetch() function where that commit
> moved to.
> 
> Thanks.
> 
> [2] https://public-inbox.org/git/xmqqd0vwcfkr.fsf@gitster-ct.c.googlers.com/ 

Yeah I still don't like it from a performance perspective, but given people rely on this functionality I've been convinced its necessary for correctness until we make other changes.

-- 
Brandon Williams
Previous: Junio C Hamano
Message 14 of 14 in “What's cooking in git.git (Jul 2018, #02; Wed, 18)”
  1. Junio C HamanoJul 18, 2018
  2. Stefan BellerJul 18, 2018
  3. Junio C HamanoJul 19, 2018
  4. Оля ТележнаяJul 19, 2018
  5. Eric SunshineJul 19, 2018
  6. Junio C HamanoJul 19, 2018
  7. Elijah NewrenJul 19, 2018
  8. ds/multi-pack-index (was Re: What's cooking in git.git (Jul 2018, #02; Wed, 18))Derrick Stolee, Jul 20, 2018
  9. Junio C HamanoJul 20, 2018
  10. Derrick StoleeJul 20, 2018
  11. ag/rebase-i-in-c, was Re: What's cooking in git.git (Jul 2018, #02; Wed, 18)Alban Gruin, Jul 20, 2018
  12. Jonathan TanJul 23, 2018
  13. Junio C HamanoJul 24, 2018
  14. Brandon WilliamsJul 24, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.