git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1] msvc: fix non-standard escape sequence in source

From
Ggit@jeffhostetler.com <git@jeffhostetler.com>
Date
Jul 24, 2018, 14:42 UTC
Message-ID
<20180724144249.2857-1-git@jeffhostetler.com>
From: Jeff Hostetler <jeffhost@microsoft.com>
Replace non-standard "\e" escape sequence with "\x1B".

In commit 7a17918c34f4e83982456ffe22d880c3cda5384f a trace message with several "\e" escape sequences was added. This causes a compiler warning under MSVC.

According to [1], the "\e" sequence is an extension supported by GCC, clang, and tcc.

[1] https://en.wikipedia.org/wiki/Escape_sequences_in_C
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
---
 convert.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/convert.c b/convert.c
index 56cfe31..52092be 100644
--- a/convert.c
+++ b/convert.c
@@ -335,7 +335,7 @@ static void trace_encoding(const char *context, const char *path,
 	strbuf_addf(&trace, "%s (%s, considered %s):\n", context, path, encoding);
 	for (i = 0; i < len && buf; ++i) {
 		strbuf_addf(
-			&trace,"| \e[2m%2i:\e[0m %2x \e[2m%c\e[0m%c",
+			&trace,"| \x1B[2m%2i:\x1B[0m %2x \x1B[2m%c\x1B[0m%c",
 			i,
 			(unsigned char) buf[i],
 			(buf[i] > 32 && buf[i] < 127 ? buf[i] : ' '),
-- 
2.9.3
Next: Eric Sunshine
Message 1 of 5 in “msvc: fix non-standard escape sequence in source”
  1. msvc: fix non-standard escape sequence in sourcegit@jeffhostetler.com, Jul 24, 2018
  2. Eric SunshineJul 24, 2018
  3. Junio C HamanoJul 24, 2018
  4. Beat BolliJul 24, 2018
  5. Jeff HostetlerJul 25, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.