git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/2 for pb/bisect-helper-2] squash! bisect--helper: `bisect_start` shell function partially in C

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Jul 23, 2018, 13:06 UTC
Message-ID
<20180723130603.22703-1-szeder.dev@gmail.com>
In-Reply-To
<20180723130230.22491-1-szeder.dev@gmail.com>
bisect--helper: use oid_to_hex()
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 builtin/bisect--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index fc02f889e6..eac4c27787 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -547,7 +547,7 @@ static int bisect_start(struct bisect_terms *terms, int no_checkout,
 		if (!get_oid(head, &head_oid) &&
 		    !starts_with(head, "refs/heads/")) {
 			strbuf_reset(&start_head);
-			strbuf_addstr(&start_head, sha1_to_hex(head_oid.hash));
+			strbuf_addstr(&start_head, oid_to_hex(&head_oid));
 		} else if (!get_oid(head, &head_oid) &&
 			   skip_prefix(head, "refs/heads/", &head)) {
 			/*
-- 
2.18.0.408.g42635c01bc
Previous: Junio C HamanoNext: Derrick Stolee
Message 7 of 9 in “travis-ci: fail if Coccinelle found something to transform”
  1. 0/2 travis-ci: fail if Coccinelle found something to transformSZEDER Gábor, Jul 23, 2018
  2. 1/2 travis-ci: run Coccinelle static analysis with two parallel jobsSZEDER Gábor, Jul 23, 2018
  3. 2/2 travis-ci: fail if Coccinelle static analysis found something to transformSZEDER Gábor, Jul 23, 2018
  4. Derrick StoleeJul 23, 2018
  5. SZEDER GáborJul 26, 2018
  6. Junio C HamanoJul 26, 2018
  7. 3/2 squash! bisect--helper: `bisect_start` shell function partially in CSZEDER Gábor, Jul 23, 2018
  8. Derrick StoleeJul 23, 2018
  9. Derrick StoleeJul 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.