git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 10/10] diff.c: offer config option to control ws handling in move detection

From
Stefan Beller <sbeller@google.com>
Date
Jul 18, 2018, 19:31 UTC
Message-ID
<20180718193156.47365-11-sbeller@google.com>
In-Reply-To
<20180718193156.47365-1-sbeller@google.com>
Signed-off-by: Stefan Beller <sbeller@google.com>
---
 Documentation/config.txt       | 5 +++++
 Documentation/diff-options.txt | 7 +++++--
 diff.c                         | 9 +++++++++
 3 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index 2659153cb37..6ca7118b018 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -1122,6 +1122,11 @@ diff.colorMoved::
 	true the default color mode will be used. When set to false,
 	moved lines are not colored.
 
+diff.colorMovedWS::
+	When moved lines are colored using e.g. the `diff.colorMoved` setting,
+	this option controls the `<mode>` how spaces are treated
+	for details of valid modes see '--color-moved-ws' in linkgit:git-diff[1].
+
 color.diff.<slot>::
 	Use customized color for diff colorization.  `<slot>` specifies
 	which part of the patch to use the specified color, and is one
diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
index 143acd9417e..8da7fed4e22 100644
--- a/Documentation/diff-options.txt
+++ b/Documentation/diff-options.txt
@@ -294,8 +294,11 @@ dimmed_zebra::
 
 --color-moved-ws=<modes>::
 	This configures how white spaces are ignored when performing the
-	move detection for `--color-moved`. These modes can be given
-	as a comma separated list:
+	move detection for `--color-moved`.
+ifdef::git-diff[]
+	It can be set by the `diff.colorMovedWS` configuration setting.
+endif::git-diff[]
+	These modes can be given as a comma separated list:
 +
 --
 ignore-space-at-eol::
diff --git a/diff.c b/diff.c
index 7810a4733f8..5089c6eb3a4 100644
--- a/diff.c
+++ b/diff.c
@@ -35,6 +35,7 @@ static int diff_rename_limit_default = 400;
 static int diff_suppress_blank_empty;
 static int diff_use_color_default = -1;
 static int diff_color_moved_default;
+static int diff_color_moved_ws_default;
 static int diff_context_default = 3;
 static int diff_interhunk_context_default;
 static const char *diff_word_regex_cfg;
@@ -332,6 +333,13 @@ int git_diff_ui_config(const char *var, const char *value, void *cb)
 		diff_color_moved_default = cm;
 		return 0;
 	}
+	if (!strcmp(var, "diff.colormovedws")) {
+		int cm = parse_color_moved_ws(value);
+		if (cm < 0)
+			return -1;
+		diff_color_moved_ws_default = cm;
+		return 0;
+	}
 	if (!strcmp(var, "diff.context")) {
 		diff_context_default = git_config_int(var, value);
 		if (diff_context_default < 0)
@@ -4327,6 +4335,7 @@ void diff_setup(struct diff_options *options)
 	}
 
 	options->color_moved = diff_color_moved_default;
+	options->color_moved_ws_handling = diff_color_moved_ws_default;
 }
 
 void diff_setup_done(struct diff_options *options)
-- 
2.18.0.233.g985f88cf7e-goog
Previous: Stefan BellerNext: Junio C Hamano
Message 11 of 12 in “[PATCHv6 00/10] Reroll of sb/diff-color-move-more”
  1. Stefan BellerJul 18, 2018
  2. 01/10 xdiff/xdiff.h: remove unused flagsStefan Beller, Jul 18, 2018
  3. 02/10 xdiff/xdiffi.c: remove unneeded function declarationsStefan Beller, Jul 18, 2018
  4. 03/10 t4015: avoid git as a pipe inputStefan Beller, Jul 18, 2018
  5. 04/10 diff.c: do not pass diff options as keydata to hashmapStefan Beller, Jul 18, 2018
  6. 05/10 diff.c: adjust hash function signature to match hashmap expectationStefan Beller, Jul 18, 2018
  7. 06/10 diff.c: add a blocks mode for moved code detectionStefan Beller, Jul 18, 2018
  8. 07/10 diff.c: decouple white space treatment from move detection algorithmStefan Beller, Jul 18, 2018
  9. 08/10 diff.c: factor advance_or_nullify out of mark_color_as_movedStefan Beller, Jul 18, 2018
  10. 09/10 diff.c: add white space mode to move detection that allows indent changesStefan Beller, Jul 18, 2018
  11. 10/10 diff.c: offer config option to control ws handling in move detectionStefan Beller, Jul 18, 2018
  12. Junio C HamanoJul 19, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.