git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/9] xdiff/xdiffi.c: remove unneeded function declarations

From
Stefan Beller <sbeller@google.com>
Date
Jul 16, 2018, 23:05 UTC
Message-ID
<20180716230542.81372-3-sbeller@google.com>
In-Reply-To
<20180716230542.81372-1-sbeller@google.com>

There is no need to forward-declare these functions, as they are used after their implementation only.

Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 xdiff/xdiffi.c | 17 -----------------
 1 file changed, 17 deletions(-)
diff --git a/xdiff/xdiffi.c b/xdiff/xdiffi.c
index 0de1ef463bf..3e8aff92bc4 100644
--- a/xdiff/xdiffi.c
+++ b/xdiff/xdiffi.c
@@ -22,34 +22,17 @@
 
 #include "xinclude.h"
 
-
-
 #define XDL_MAX_COST_MIN 256
 #define XDL_HEUR_MIN_COST 256
 #define XDL_LINE_MAX (long)((1UL << (CHAR_BIT * sizeof(long) - 1)) - 1)
 #define XDL_SNAKE_CNT 20
 #define XDL_K_HEUR 4
 
-
-
 typedef struct s_xdpsplit {
 	long i1, i2;
 	int min_lo, min_hi;
 } xdpsplit_t;
 
-
-
-
-static long xdl_split(unsigned long const *ha1, long off1, long lim1,
-		      unsigned long const *ha2, long off2, long lim2,
-		      long *kvdf, long *kvdb, int need_min, xdpsplit_t *spl,
-		      xdalgoenv_t *xenv);
-static xdchange_t *xdl_add_change(xdchange_t *xscr, long i1, long i2, long chg1, long chg2);
-
-
-
-
-
 /*
  * See "An O(ND) Difference Algorithm and its Variations", by Eugene Myers.
  * Basically considers a "box" (off1, off2, lim1, lim2) and scan from both
-- 
2.18.0.203.gfac676dfb9-goog
Previous: Stefan BellerNext: Stefan Beller
Message 3 of 12 in “[PATCHv5 0/9] Reroll of sb/diff-color-move-more”
  1. Stefan BellerJul 16, 2018
  2. 1/9 xdiff/xdiff.h: remove unused flagsStefan Beller, Jul 16, 2018
  3. 2/9 xdiff/xdiffi.c: remove unneeded function declarationsStefan Beller, Jul 16, 2018
  4. 3/9 t4015: avoid git as a pipe inputStefan Beller, Jul 16, 2018
  5. 4/9 diff.c: do not pass diff options as keydata to hashmapStefan Beller, Jul 16, 2018
  6. 5/9 diff.c: adjust hash function signature to match hashmap expectationStefan Beller, Jul 16, 2018
  7. 6/9 diff.c: add a blocks mode for moved code detectionStefan Beller, Jul 16, 2018
  8. 7/9 diff.c: decouple white space treatment from move detection algorithmStefan Beller, Jul 16, 2018
  9. 8/9 diff.c: factor advance_or_nullify out of mark_color_as_movedStefan Beller, Jul 16, 2018
  10. 9/9 diff.c: add white space mode to move detection that allows indent changesStefan Beller, Jul 16, 2018
  11. Andrei RybakJul 18, 2018
  12. Stefan BellerJul 18, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.