Re: Git 2.18: RUNTIME_PREFIX... is it working?

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jul 14, 2018, 20:51 UTC
Message-ID: <20180714205132.GH1042117@genre.crustytoothpaste.net>
In-Reply-To: <20180710140310.GA9246@sigill.intra.peff.net>

On Tue, Jul 10, 2018 at 10:03:10AM -0400, Jeff King wrote:

Show 6 quoted lines

> My point is that aside from RUNTIME_PREFIX, we don't need /proc. So
> somebody who currently builds Git with a static path like
> "/usr/libexec/git-core" and runs it inside a chroot will be just fine as
> long as /usr/libexec/git-core is available at that name inside the
> chroot. But if the build starts relying on RUNTIME_PREFIX, it's going to
> regress their case.

I will say that at cPanel, we have a configuration where end users can end up inside a mount namespace without /proc (depending on the preferences of the administrator). However, it's easy enough for us to simply build without RUNTIME_PREFIX if necessary.

If we turn it on by default, it would be nice if we documented (maybe in the Makefile) that it requires /proc on Linux for the benefit of other people who might be in a similar situation.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204