Re: What's cooking in git.git (Jul 2018, #01; Wed, 11)

From: Jeff King <peff@peff.net>
Date: Jul 13, 2018, 19:52 UTC
Message-ID: <20180713195230.GA11860@sigill.intra.peff.net>
In-Reply-To: <xmqq7em138a5.fsf@gitster-ct.c.googlers.com>

On Wed, Jul 11, 2018 at 12:02:42PM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> * jk/fsck-gitmodules-gently (2018-07-03) 5 commits
>  - fsck: silence stderr when parsing .gitmodules
>  - fsck: silence stderr when parsing .gitmodules
>  - config: add options parameter to git_config_from_mem
>  - config: add CONFIG_ERROR_SILENT handler
>  - config: turn die_on_error into caller-facing enum
> 
>  What's the status of this one?

I think the bottom 4 are fine. We should drop the top "something like this" patch, and replace it with two patches I just sent in that thread:

  https://public-inbox.org/git/20180713193759.GB10354@sigill.intra.peff.net/

Note the bit I mentioned about building it in the opposite order; let me know if you'd prefer that.

There's also some discussion there about queuing Ramsay's skiplist patch separately. It looks like you already have rj/submodule-fsck-skip marked for merging to master, which is fine.

-Peff