Re: [PATCH] fsck: check skiplist for object in fsck_blob()

From: Jeff King <peff@peff.net>
Date: Jul 13, 2018, 19:41 UTC
Message-ID: <20180713194119.GC10354@sigill.intra.peff.net>
In-Reply-To: <6b323eff-a0a6-d8d3-1e40-70af8299db5f@ramsayjones.plus.com>

On Fri, Jul 13, 2018 at 08:37:46PM +0100, Ramsay Jones wrote:

> OK, so I found some time to test this tonight. It is not good
> news (assuming that I haven't messed up the testing, of course). :(

I think you may have. :)

Show 9 quoted lines

>   not ok 18 - push rejects corrupt .gitmodules (policy)
>   #	
>   #		rm -rf dst.git &&
>   #		git init --bare dst.git &&
>   #		git -C dst.git config transfer.fsckObjects true &&
>   #		git -C dst.git config fsck.gitmodulesParse error &&
>   #		test_must_fail git -C corrupt push ../dst.git HEAD 2>output &&
>   #		grep gitmodulesParse output &&
>   #		test_i18ngrep ! "bad config" output

There are separate config slots for local fsck versus receiving objects. So I think you need to be setting receive.fsck.gitmodulesParse.

-Peff