git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] has_uncommitted_changes(): fall back to empty tree

From
Jeff King <peff@peff.net>
Date
Jul 11, 2018, 15:00 UTC
Message-ID
<20180711150012.GD15269@sigill.intra.peff.net>
In-Reply-To
<87in5ldedd.fsf@evledraar.gmail.com>
On Wed, Jul 11, 2018 at 04:41:02PM +0200, Ævar Arnfjörð Bjarmason wrote:
Show 6 quoted lines
> > [From upthread]: It took me a minute to reproduce this. It needs "pull
> > --rebase" if you don't have that setup in your config.
> 
> Yeah, sorry about that. I tested without --rebase while simplifying the
> testcase, but forgot that I have pull.rebase=true in my ~/.gitconfig, so
> of course that didn't imply --no-rebase.
In the grand scheme of things, it was still a pretty good bug report. :)

Having the stack trace meant that the head-scratching was "why am I not calling the problem function", rather than "why am I not reproducing", which is much easier to track down.

-Peff
Previous: Ævar Arnfjörð BjarmasonNext: Junio C Hamano
Message 5 of 7 in “BUG: Segfault on "git pull" on "bad object HEAD"”
  1. Ævar Arnfjörð BjarmasonJul 11, 2018
  2. Jeff KingJul 11, 2018
  3. has_uncommitted_changes(): fall back to empty treeJeff King, Jul 11, 2018
  4. Ævar Arnfjörð BjarmasonJul 11, 2018
  5. Jeff KingJul 11, 2018
  6. Junio C HamanoJul 11, 2018
  7. Duy NguyenJul 11, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.