Re: [PATCH] builtin/config: work around an unsized array forward declaration

From: Jeff King <peff@peff.net>
Date: Jul 5, 2018, 20:02 UTC
Message-ID: <20180705200205.GA29861@sigill.intra.peff.net>
In-Reply-To: <phlsmp$mot$1@blaine.gmane.org>

On Thu, Jul 05, 2018 at 09:50:53PM +0200, Beat Bolli wrote:

Show 11 quoted lines

> > Your patch is obviously correct, but I think here there might be an even
> > simpler solution: just bump option_parse_type() below the declaration,
> > since it's the only one that needs it. That hunk is bigger, but the
> > overall diff is simpler, and we don't need to carry that extra wrapper
> > function.
> 
> That was dscho's first try in the GitHub issue. It doesn't compile
> because the OPT_CALLBACK* macros in the builtin_config_options
> declaration inserts a pointer to option_parse_type into the array items.
> We need at least one forward declaration, and my patch seemed the least
> intrusive.

Ah, right, so it actually is mutually recursive. Forward-declaring option_parse_type() would fix it, along with the reordering. I'm ambivalent between the available options, then; we might as well go with what you posted, then, since it's already done. :)

-Peff