git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] i18n: bisect: mark three supplementary strings for translation

From
Raphaël Hertzog <hertzog@debian.org>
Date
Jul 4, 2018, 15:43 UTC
Message-ID
<20180704154357.26964-3-hertzog@debian.org>
In-Reply-To
<20180704154357.26964-1-hertzog@debian.org>

The whole bisect procedure is translated but the last message that the user will see in the process is not translated. Let's fix this.

Also mark the "revision walk setup failed" error message for translation. It's already used in other files so will not generate any new string to translate.

Signed-off-by: Raphaël Hertzog <hertzog@debian.org>
---
 bisect.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/bisect.c b/bisect.c
index 6de1abd40..678df54cc 100644
--- a/bisect.c
+++ b/bisect.c
@@ -653,7 +653,7 @@ static void bisect_rev_setup(struct rev_info *revs, const char *prefix,
 static void bisect_common(struct rev_info *revs)
 {
 	if (prepare_revision_walk(revs))
-		die("revision walk setup failed");
+		die(_("revision walk setup failed"));
 	if (revs->tree_objects)
 		mark_edges_uninteresting(revs, NULL);
 }
@@ -664,8 +664,8 @@ static void exit_if_skipped_commits(struct commit_list *tried,
 	if (!tried)
 		return;
 
-	printf("There are only 'skip'ped commits left to test.\n"
-	       "The first %s commit could be any of:\n", term_bad);
+	printf(_("There are only 'skip'ped commits left to test.\n"
+		 "The first %s commit could be any of:\n"), term_bad);
 
 	for ( ; tried; tried = tried->next)
 		printf("%s\n", oid_to_hex(&tried->item->object.oid));
@@ -990,7 +990,7 @@ int bisect_next_all(const char *prefix, int no_checkout)
 
 	if (!oidcmp(bisect_rev, current_bad_oid)) {
 		exit_if_skipped_commits(tried, current_bad_oid);
-		printf("%s is the first %s commit\n", oid_to_hex(bisect_rev),
+		printf(_("%s is the first %s commit\n"), oid_to_hex(bisect_rev),
 			term_bad);
 		show_diff_tree(prefix, revs.commits->item);
 		/* This means the bisection process succeeded. */
-- 
2.18.0
Previous: Junio C Hamano
Message 5 of 5 in “Two small l10n/i18n patches (resend)”
  1. Raphaël HertzogJul 4, 2018
  2. 1/2 l10n: fr: fix a message seen in git bisectRaphaël Hertzog, Jul 4, 2018
  3. Jean-Noël AvilaJul 4, 2018
  4. Junio C HamanoJul 6, 2018
  5. 2/2 i18n: bisect: mark three supplementary strings for translationRaphaël Hertzog, Jul 4, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.