git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 06/12] diffcore.h: drop extern from function declaration

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Jun 30, 2018, 09:20 UTC
Message-ID
<20180630092031.29910-7-pclouds@gmail.com>
In-Reply-To
<20180630092031.29910-1-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 diffcore.h | 50 +++++++++++++++++++++++++-------------------------
 1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/diffcore.h b/diffcore.h
index a30da161da..81281a398b 100644
--- a/diffcore.h
+++ b/diffcore.h
@@ -50,17 +50,17 @@ struct diff_filespec {
 	struct userdiff_driver *driver;
 };
 
-extern struct diff_filespec *alloc_filespec(const char *);
-extern void free_filespec(struct diff_filespec *);
-extern void fill_filespec(struct diff_filespec *, const struct object_id *,
-			  int, unsigned short);
+struct diff_filespec *alloc_filespec(const char *);
+void free_filespec(struct diff_filespec *);
+void fill_filespec(struct diff_filespec *, const struct object_id *,
+		   int, unsigned short);
 
 #define CHECK_SIZE_ONLY 1
 #define CHECK_BINARY    2
-extern int diff_populate_filespec(struct diff_filespec *, unsigned int);
-extern void diff_free_filespec_data(struct diff_filespec *);
-extern void diff_free_filespec_blob(struct diff_filespec *);
-extern int diff_filespec_is_binary(struct diff_filespec *);
+int diff_populate_filespec(struct diff_filespec *, unsigned int);
+void diff_free_filespec_data(struct diff_filespec *);
+void diff_free_filespec_blob(struct diff_filespec *);
+int diff_filespec_is_binary(struct diff_filespec *);
 
 struct diff_filepair {
 	struct diff_filespec *one;
@@ -86,9 +86,9 @@ struct diff_filepair {
 
 #define DIFF_PAIR_MODE_CHANGED(p) ((p)->one->mode != (p)->two->mode)
 
-extern void diff_free_filepair(struct diff_filepair *);
+void diff_free_filepair(struct diff_filepair *);
 
-extern int diff_unmodified_pair(struct diff_filepair *);
+int diff_unmodified_pair(struct diff_filepair *);
 
 struct diff_queue_struct {
 	struct diff_filepair **queue;
@@ -102,16 +102,16 @@ struct diff_queue_struct {
 	} while (0)
 
 extern struct diff_queue_struct diff_queued_diff;
-extern struct diff_filepair *diff_queue(struct diff_queue_struct *,
-					struct diff_filespec *,
-					struct diff_filespec *);
-extern void diff_q(struct diff_queue_struct *, struct diff_filepair *);
+struct diff_filepair *diff_queue(struct diff_queue_struct *,
+				 struct diff_filespec *,
+				 struct diff_filespec *);
+void diff_q(struct diff_queue_struct *, struct diff_filepair *);
 
-extern void diffcore_break(int);
-extern void diffcore_rename(struct diff_options *);
-extern void diffcore_merge_broken(void);
-extern void diffcore_pickaxe(struct diff_options *);
-extern void diffcore_order(const char *orderfile);
+void diffcore_break(int);
+void diffcore_rename(struct diff_options *);
+void diffcore_merge_broken(void);
+void diffcore_pickaxe(struct diff_options *);
+void diffcore_order(const char *orderfile);
 
 /* low-level interface to diffcore_order */
 struct obj_order {
@@ -138,11 +138,11 @@ void diff_debug_queue(const char *, struct diff_queue_struct *);
 #define diff_debug_queue(a,b) do { /* nothing */ } while (0)
 #endif
 
-extern int diffcore_count_changes(struct diff_filespec *src,
-				  struct diff_filespec *dst,
-				  void **src_count_p,
-				  void **dst_count_p,
-				  unsigned long *src_copied,
-				  unsigned long *literal_added);
+int diffcore_count_changes(struct diff_filespec *src,
+			   struct diff_filespec *dst,
+			   void **src_count_p,
+			   void **dst_count_p,
+			   unsigned long *src_copied,
+			   unsigned long *literal_added);
 
 #endif
-- 
2.18.0.rc2.476.g39500d3211
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 6 of 17 in “Kill the_index part2, header file cleanup”
  1. 00/12 Kill the_index part2, header file cleanupNguyễn Thái Ngọc Duy, Jun 30, 2018
  2. 02/12 attr.h: drop extern from function declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  3. 01/12 apply.h: drop extern on func declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  4. 03/12 blame.h: drop extern on func declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  5. 05/12 convert.h: drop 'extern' from function declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  6. 06/12 diffcore.h: drop extern from function declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  7. 04/12 cache-tree.h: drop extern from function declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  8. 07/12 diff.h: remove extern from function declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  9. 10/12 repository.h: drop extern from function declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  10. 08/12 line-range.h: drop extern from function declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  11. 09/12 rerere.h: drop extern from function declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  12. 11/12 revision.h: drop extern from function declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  13. 12/12 submodule.h: drop extern from function declarationNguyễn Thái Ngọc Duy, Jun 30, 2018
  14. Brandon WilliamsJul 2, 2018
  15. Duy NguyenJul 21, 2018
  16. Duy NguyenAug 3, 2018
  17. Junio C HamanoAug 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.