Re: [PATCH v2 5/6] submodule-config: pass repository as argument to config_from_gitmodules

From: Antonio Ospite <ao2@ao2.it>
Date: Jun 26, 2018, 20:57 UTC
Message-ID: <20180626225739.eb839a246db6037ff8996782@ao2.it>
In-Reply-To: <xmqq7emljod6.fsf@gitster-ct.c.googlers.com>

On Tue, 26 Jun 2018 13:15:33 -0700 Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> Antonio Ospite <ao2@ao2.it> writes:
> 
> > Generlize config_from_gitmodules to accept a repository as an argument.
> 
> generalize???
>

Of course I was going to miss a typo in the first word of the commit message :|

If this is the only change, I'd ask you to amend it when applying the patch, if it's not too much trouble.

If instead I have to add also the comments about the new public functions in submodule-config.c, as you asked for patch 2/6, I can send a v3 and fix the typo there.

Thanks,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?