Re: [PATCH] protocol-v2 doc: put HTTP headers after request

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 22, 2018, 19:37 UTC
Message-ID: <20180622193757.GF12013@aiede.svl.corp.google.com>
In-Reply-To: <20180622190112.7559-1-steadmon@google.com>

Josh Steadmon wrote:

Show 6 quoted lines

> HTTP servers return 400 if you send headers before the GET request.
>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
> ---
>  Documentation/technical/protocol-v2.txt | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks.  Congrats on your first patch! ;-)

Tested using

  openssl s_client -connect github.com:443

with input

  GET /git/git/info/refs?service=git-upload-pack HTTP/1.0
  Host: github.com
  Git-Protocol: version=2

which produces a 404 instead of the 400 that putting Git-Protocol in front would produce.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>