Re: Adding nested repository with slash adds files instead of gitlink

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Jun 19, 2018, 10:36 UTC
Message-ID: <20180619103632.GC10085@book.hvoigt.net>
In-Reply-To: <20180618181215.GB73085@google.com>

On Mon, Jun 18, 2018 at 11:12:15AM -0700, Brandon Williams wrote:

Show 10 quoted lines

> On 06/18, Duy Nguyen wrote:
> > This sounds like the submodule specific code in pathspec.c, which has
> > been replaced with something else in bw/pathspec-sans-the-index. If
> > you have time, try a version without those changes (e.g. v2.13 or
> > before) to see if it's a possible culprit.
> 
> I just tested this with v2.13 and saw the same issue.  I don't actually
> think this ever worked in the way you want it to Heiko.  Maybe git add
> needs to be taught to be more intelligent when trying to add a submodule
> which doesn't exist in the index.

That was also my guess, since my feeling is that this is a quite rare use case. Adding submodules alone is not a daily thing, let alone selecting different changes after 'git submodule add'.

I also think git could be more intelligent here.

Cheers Heiko