git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/6] git-p4: python3: fix octal constants

From
Luke Diamand <luke@diamand.org>
Date
Jun 19, 2018, 08:04 UTC
Message-ID
<20180619080411.6554-7-luke@diamand.org>
In-Reply-To
<20180619080411.6554-6-luke@diamand.org>
See PEP3127. Works fine with python2 as well.
Signed-off-by: Luke Diamand <luke@diamand.org>
---
 git-p4.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-p4.py b/git-p4.py
index 714e442d7c..b449db1cc9 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1841,7 +1841,7 @@ def applyCommit(self, id):
                     filesToDelete.remove(path)
 
                 dst_mode = int(diff['dst_mode'], 8)
-                if dst_mode == 0120000:
+                if dst_mode == 0o120000:
                     symlinks.add(path)
 
             elif modifier == "D":
-- 
2.18.0.rc1.242.g61856ae69a
Previous: Luke DiamandNext: Eric Sunshine
Message 7 of 8 in “git-p4: small step towards Python3 support”
  1. 0/6 git-p4: small step towards Python3 supportLuke Diamand, Jun 19, 2018
  2. 1/6 git-p4: python3: replace <> with !=Luke Diamand, Jun 19, 2018
  3. 2/6 git-p4: python3: replace dict.has_key(k) with "k in dict"Luke Diamand, Jun 19, 2018
  4. 3/6 git-p4: python3: remove backticksLuke Diamand, Jun 19, 2018
  5. 4/6 git-p4: python3: basestring workaroundLuke Diamand, Jun 19, 2018
  6. 5/6 git-p4: python3: use print() functionLuke Diamand, Jun 19, 2018
  7. 6/6 git-p4: python3: fix octal constantsLuke Diamand, Jun 19, 2018
  8. Eric SunshineJun 19, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.